perf: dynamic dory commitment computation on the GPU should have parallel option #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayWhite2357
requested changes
Oct 21, 2024
crates/proof-of-sql/src/proof_primitive/dory/blitzar_metadata_table.rs
Outdated
Show resolved
Hide resolved
crates/proof-of-sql/src/proof_primitive/dory/blitzar_metadata_table.rs
Outdated
Show resolved
Hide resolved
crates/proof-of-sql/src/proof_primitive/dory/dynamic_dory_commitment_helper_gpu.rs
Outdated
Show resolved
Hide resolved
crates/proof-of-sql/src/proof_primitive/dory/blitzar_metadata_table.rs
Outdated
Show resolved
Hide resolved
JayWhite2357
previously approved these changes
Oct 22, 2024
…helper_gpu and blitzar_metadata_table modules
… blitzar_metadata_table module
…itzar_metadata_table modules
jacobtrombetta
force-pushed
the
perf/parallel-dynamic-dory
branch
from
ae3c542
to
025c55a
Compare
JayWhite2357
approved these changes
Oct 22, 2024
|
🎉 This PR is included in version 0.33.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The dynamic Dory commitment computation can utilize the GPU. This PR introduces some parallelism to the code if the
rayonfeature is used when compiling.What changes are included in this PR?
if_rayonmacro in theblitzar_metadata_tableanddynamic_dory_commitment_helper_gpumodules.Are these changes tested?
Yes